Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yank warnings at end of messages #1669

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add yank warnings at end of messages #1669

merged 1 commit into from
Feb 19, 2024

Conversation

dwreeves
Copy link
Contributor

Resolves #1292.

Summary

Move the yanked warnings for uv pip sync and uv pip install to the end of the commands, as per #1292.

Test Plan

I ran the unit tests: cargo nextest run

zanieb
zanieb approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zanieb zanieb added the error messages Messaging when something goes wrong label Feb 19, 2024
@zanieb zanieb merged commit e923dba into astral-sh:main Feb 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
error messages Messaging when something goes wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yank warnings should display at the end
2 participants
@dwreeves @zanieb