Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.1.7 broke AWS CodeArtifact #1860

Closed
bra-fsn opened this issue Feb 22, 2024 · 2 comments · Fixed by #1874
Closed

0.1.7 broke AWS CodeArtifact #1860

bra-fsn opened this issue Feb 22, 2024 · 2 comments · Fixed by #1874
Assignees
@zanieb
Labels
bug Something isn't working registry Related to package indexes and registries

Comments

@bra-fsn
Copy link

bra-fsn commented Feb 22, 2024

I use AWS CodeArtifact to store/get local Python packages.
After getting a token for it and specifying the URL with uv's --extra-index-url, I can install those packages with uv pip install $pkg_name --extra-index-url "$URL" with uv version 0.1.6, but I get the following error using 0.1.7:

uv pip install $pkg_name --extra-index-url "$URL"
error: Failed to download: $pkg_name==1.2.5
  Caused by: HTTP status client error (401 Unauthorized) for url (https://XXX-packages-XXX.d.codeartifact.us-west-2.amazonaws.com/pypi/python/simple/$pkg_name/1.2.5/$pkg_name-1.2.5-py3-none-any.whl#sha256=f168c68d34f2404c9d9289406a9e340ede6224888baceba18dfb980912fe73ae)
@zanieb zanieb self-assigned this Feb 22, 2024
@zanieb zanieb added the bug Something isn't working label Feb 22, 2024
@zanieb
Copy link
Member

zanieb commented Feb 22, 2024

I can confirm this is a regression from 0.1.6 to 0.1.7, thanks for the report!

@zanieb zanieb added the registry Related to package indexes and registries label Feb 22, 2024
@zanieb zanieb mentioned this issue Feb 22, 2024
Merged
zanieb added a commit that referenced this issue Feb 22, 2024
@zanieb
Retain authentication attached to URLs when making requests to the sa…
86052fb 
…me host (#1874)

Closes #1860


In #1816, we started using the URL
attached to a response instead of the request URL for subsequent
requests — this fixes various bugs but has the side-effect of dropping
credentials from the URL. Here, we transfer credentials from the request
URL to the response URL. We perform RFC compliant checks for safety.
@zanieb
Copy link
Member

zanieb commented Feb 22, 2024

This should be resolved in v0.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanieb zanieb

Labels
bug Something isn't working registry Related to package indexes and registries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retain authentication attached to URLs when making requests to the same host astral-sh/uv
2 participants
@bra-fsn @zanieb