Use redirected URL as base for relative paths #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/base
branch
from
2969375
to
cbfac0d
Compare
zanieb
added a commit
that referenced
this pull request
Feb 22, 2024
…me host (#1874) Closes #1860 In #1816, we started using the URL attached to a response instead of the request URL for subsequent requests — this fixes various bugs but has the side-effect of dropping credentials from the URL. Here, we transfer credentials from the request URL to the response URL. We perform RFC compliant checks for safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you review the setup in #1747, when we fetch
http://localhost:8000/simple/wheel/, it gets redirected tohttp://localhost:8000/index/wheel/. So any relative paths returned need to be resolved relative tohttp://localhost:8000/index/wheel/.Closes #1747.
Test Plan
proxpi gunicorn pypiservergunicorn proxpi.server:app --bind 0.0.0.0:8000pypi-server run -p 8080 ~/packages --fallback-url "http://localhost:8000/index" --verboseecho "wheel" | cargo run pip compile - --index-url http://localhost:8080/simple --verbose --no-cache