Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universal-lock: include and verify Python version range in the lock file #4052

Closed
zanieb opened this issue Jun 5, 2024 · 1 comment · Fixed by #4068
Closed

universal-lock: include and verify Python version range in the lock file #4052

zanieb opened this issue Jun 5, 2024 · 1 comment · Fixed by #4068
Assignees
Labels
preview Experimental behavior

Comments

@zanieb
Copy link
Member

zanieb commented Jun 5, 2024

Mentioned at #4050 (comment)

We should include the Python requirement in the lock file and verify that it is fulfilled on sync.

@charliermarsh
Copy link
Member

I can take this.

charliermarsh added a commit that referenced this issue Jun 5, 2024
## Summary

This PR adds the `Requires-Python` range to the user's lockfile. This
will enable us to validate it when installing.

For now, we repeat the `Requires-Python` back to the user;
alternatively, though, we could detect the supported Python range
automatically.

See: #4052
charliermarsh added a commit that referenced this issue Jun 5, 2024
## Summary

Ensures that we raise if the user attempts to use a Python version that
wasn't included in the locked range.

Closes #4052.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Experimental behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants