Enforce Requires-Python when syncing
#4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/requires-python
branch
from
6b26540
to
d330570
Compare
charliermarsh
force-pushed
the
charlie/requires-python-ii
branch
from
37570c6
to
74b82a9
Compare
charliermarsh
commented
Jun 5, 2024
| return Err(ProjectError::RequiresPython( | ||
| venv.interpreter().python_version().clone(), | ||
| requires_python.clone(), | ||
| )); |
There was a problem hiding this comment.
Should this be a warning?
There was a problem hiding this comment.
Probably not, I feel like for a lockfile it makes sense to fail?
zanieb
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that we raise if the user attempts to use a Python version that wasn't included in the locked range.
Closes #4052.