Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -U/-P short flags for --upgrade/--upgrade-package #1394

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Add -U/-P short flags for --upgrade/--upgrade-package #1394

merged 2 commits into from
Feb 16, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Feb 16, 2024

Closes #1340

@zanieb zanieb changed the title Add -U short flag for --upgrade Add -U/-P short flags for --upgrade/--upgrade-package Feb 16, 2024
@zanieb zanieb added enhancement New feature or request compatibility Compatibility with a specification or another tool and removed enhancement New feature or request labels Feb 16, 2024
upgrade: bool,

/// Allow upgrades for a specific package, ignoring pinned versions in the existing output
/// file.
#[clap(long)]
#[clap(long, short = 'P')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find -P unexpected, but I see that this is what pip-tools does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too 🤷‍♀️ seems okay for this interface

Base automatically changed from zb/upgrade-pip-install to main February 16, 2024 01:25
@zanieb zanieb enabled auto-merge (squash) February 16, 2024 01:26
@zanieb zanieb merged commit 0f554b0 into main Feb 16, 2024
7 checks passed
@zanieb zanieb deleted the zb/pip-U branch February 16, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility with a specification or another tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants