Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -U/-P short flags for --upgrade/--upgrade-package #1394

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Add -U/-P short flags for --upgrade/--upgrade-package #1394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a04d06
Add `-U` short flag for `--upgrade`
zanieb Feb 16, 2024
9d09563
Add `-P` alias for `--upgrade-package`
zanieb Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/uv/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,12 +256,12 @@ struct PipCompileArgs {
find_links: Vec<FlatIndexLocation>,

/// Allow package upgrades, ignoring pinned versions in the existing output file.
#[clap(long)]
#[clap(long, short = 'U')]
upgrade: bool,

/// Allow upgrades for a specific package, ignoring pinned versions in the existing output
/// file.
#[clap(long)]
#[clap(long, short = 'P')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find -P unexpected, but I see that this is what pip-tools does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too 🤷‍♀️ seems okay for this interface

upgrade_package: Vec<PackageName>,

/// Include distribution hashes in the output file.
Expand Down Expand Up @@ -471,11 +471,11 @@ struct PipInstallArgs {
all_extras: bool,

/// Allow package upgrades.
#[clap(long)]
#[clap(long, short = 'U')]
upgrade: bool,

/// Allow upgrade of a specific package.
#[clap(long)]
#[clap(long, short = 'P')]
upgrade_package: Vec<PackageName>,

/// Reinstall all packages, regardless of whether they're already installed.
Expand Down