Generate versioned pip launchers #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users expect pip to have `pip`, `pip3` and `pip3.x` entrypoints. But pip is a universal wheel, so it contains the `pip3.x` entrypoint where it was built on. To fix this, pip special cases itself when installing (https://github.com/pypa/pip/blob/3898741e29b7279e7bffe044ecfbe20f6a438b1e/src/pip/_internal/operations/install/wheel.py#L283), replacing the wheel entrypoint with one for the current version. We now do the same. Fixes #1593
konstin
added
bug
zanieb
approved these changes
Feb 23, 2024
konstin
added a commit
that referenced
this pull request
Feb 26, 2024
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoints. Closes #1593.
konstin
added a commit
that referenced
this pull request
Feb 26, 2024
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoints. Closes #1593.
konstin
added a commit
that referenced
this pull request
Feb 28, 2024
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoints. Closes #1593.
konstin
added a commit
that referenced
this pull request
Mar 1, 2024
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoint. The pip test is semi-functional since it builds pip from source instead of using a wheel with the wrong entrypoint, we have to update it when this pip version has a release. Closes #1593.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users expect pip to have
pip,pip3andpip3.xentrypoints. But pip is a universal wheel, so it contains thepip3.xentrypoint where it was built on. To fix this, pip special cases itself when installing (https://github.com/pypa/pip/blob/3898741e29b7279e7bffe044ecfbe20f6a438b1e/src/pip/_internal/operations/install/wheel.py#L283), replacing the wheel entrypoint with one for the current version. We now do the same.Fixes #1593