Future-proof pip entrypoints special case #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
added
the
compatibility
konstin
commented
Feb 26, 2024
| .arg("requirements.txt") | ||
| .arg("--strict") | ||
| .output() | ||
| .expect("Failed to install pip"); |
There was a problem hiding this comment.
I'd skip the output here since it's different for the two different versions
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoints. Closes #1593.
konstin
force-pushed
the
konsti/update-pip-special-case
branch
from
6cdc18a
to
ddd6768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoint. The pip test is semi-functional since it builds pip from source instead of using a wheel with the wrong entrypoint, we have to update it when this pip version has a release.
Closes #1593.