Allow conflicting Git URLs that refer to the same commit SHA #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/allowed-urls
branch
2 times, most recently
from
164a873
to
cae49a0
Compare
|
Nice. I'll give this a real read in the morning. |
|
Thanks :) |
charliermarsh
force-pushed
the
charlie/allowed-urls
branch
from
cae49a0
to
5331729
Compare
zanieb
reviewed
Apr 2, 2024
zanieb
approved these changes
Apr 2, 2024
charliermarsh
force-pushed
the
charlie/allowed-urls
branch
2 times, most recently
from
b01ac6d
to
7f0f233
Compare
charliermarsh
force-pushed
the
charlie/allowed-urls
branch
from
7f0f233
to
ffa8302
Compare
charliermarsh
added a commit
that referenced
this pull request
Apr 3, 2024
## Summary I noticed in #2769 that I was now stripping `.git` suffixes from Git URLs after resolving to a precise commit. This PR cleans up the internal caching to use a better canonical representation: a `RepositoryUrl` along with a `GitReference`, instead of a `GitUrl` which can contain non-canonical data. This gives us both better fidelity (preserving the `.git`, along with any casing that the user provided when defining the URL) and is overall cleaner and more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR leverages our lookahead direct URL resolution to significantly improve the range of Git URLs that we can accept (e.g., if a user provides the same requirement, once as a direct dependency, and once as a tag). We did some of this in #2285, but the solution here is more general and works for arbitrary transitive URLs.
Closes #2614.