Add --workspace option to uv add
#4362
Conversation
ibraheemdev
force-pushed
the
ibraheem/uv-add-workspace
branch
from
acd8695
to
eec7bd7
Compare
| source: Option<&Source>, | ||
| ) -> Result<(), Error> { | ||
| // Get or create `project.dependencies`. | ||
| let dependencies = self |
There was a problem hiding this comment.
toml_edit does some implicit conversions/insertion when indexing directly on an Item which makes this form a lot better.. but very verbose. Maybe an extension trait could help for some of the common conversions.
ibraheemdev
force-pushed
the
ibraheem/uv-add-workspace
branch
2 times, most recently
from
74637e7
to
d714a7f
Compare
ibraheemdev
force-pushed
the
ibraheem/uv-add-workspace
branch
from
d714a7f
to
dc9e675
Compare
crates/uv/tests/edit.rs
Outdated
| + project==0.1.0 (from file://[TEMP_DIR]/) | ||
| + sniffio==1.3.1 | ||
| warning: `uv remove` is experimental and may change without warning. | ||
| warning: `anyio` is a development dependency; try calling `uv add --dev` |
There was a problem hiding this comment.
Should this be uv remove --dev?
There was a problem hiding this comment.
Great catch, thanks.
| /// Add the requirements as workspace dependencies. | ||
| #[arg(long)] | ||
| pub(crate) workspace: bool, |
There was a problem hiding this comment.
I'm on the fence whether we need an explicit argument for this, we could also do workspace discovery and know that it has to be a workspace dep, otoh it's consistent with us requiring workspace = true in pyproject.toml (it's something we took from cargo, it's helpful to make we don't accidentally flip between workspace and index and to keep the information about the package source local)
It was becoming problematic that the virtual environment test context diverged from the other one i.e. we had to implement filtering twice. This combines the contexts and tweaks the `TestContext` API and filtering mechanisms for Python versions. Combined with my previous changes to the test context at #4364 and #4368 this finally unblocks the snapshots for test cases in #4360 and #4362.
ibraheemdev
force-pushed
the
ibraheem/uv-add-workspace
branch
from
c553fdb
to
8f103b3
Compare
Summary
Implements
uv add foo --workspace, which addsfooas a workspace dependency with the correspondingtool.uv.sourcesentry.Part of #3959.