-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move virtual environment test context into main context #4370
Conversation
7680651
to
a0e377e
Compare
4d76cfb
to
b2a114d
Compare
$Volume = New-VHD -Path C:/uv_dev_drive.vhdx -SizeBytes 10GB | | ||
$Volume = New-VHD -Path C:/uv_dev_drive.vhdx -SizeBytes 12GB | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows test builds failed with the mysterious LINK : fatal error LNK1318: Unexpected PDB error; LIMIT
without this
60789c6
to
e6f41ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This improves the test filters a lot
r+ me with the two test regressions fixed
It was becoming problematic that the virtual environment test context diverged from the other one i.e. we had to implement filtering twice. This combines the contexts and tweaks the
TestContext
API and filtering mechanisms for Python versions. Combined with my previous changes to the test context at #4364 and #4368 this finally unblocks the snapshots for test cases in #4360 and #4362.