fix the incorrect handling of markers in pip tree
#4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zanieb also oops noticed the cycle message still uses # 😭 (seems like i messed up the merge conflict) i can make a follow-up sometime to fix that as well |
|
there seem to be a bunch of CI failures from 429... (i'll try re-triggering tomorrow or something) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #4609
previously, the implementation of
required_with_no_extrawas incorrect, particularly when there are packages that do not require any extras but have other types of markers.Test Plan
the existing tests also did cover this (my bad... missed it) but added a smaller test since this bug would've been more obvious with this new test.