use asterisk for dependency cycle too #4626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zanieb fyi |
ibraheemdev
reviewed
Jun 28, 2024
| └── uv-cyclic-dependencies-a v0.1.0 (#) | ||
| (#) Dependency cycle | ||
| └── uv-cyclic-dependencies-a v0.1.0 (*) | ||
| (*) Package tree already displayed |
There was a problem hiding this comment.
Why is the message changing?
There was a problem hiding this comment.
Ah I see, if --no-dedupe isn't passed we se the same message for both.
ibraheemdev
approved these changes
Jun 28, 2024
zanieb
reviewed
Jun 28, 2024
crates/uv/src/commands/pip/tree.rs
Outdated
| printer.stdout(), | ||
| "{}", | ||
| let message = if no_dedupe { | ||
| "(*) Dependency cycle".italic() |
There was a problem hiding this comment.
Should we say "Package tree is a cycle and cannot be shown" as we discussed before?
There was a problem hiding this comment.
Or "Package tree forms/contains a cycle and cannot be shown"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#4611 (comment) #4449 (comment) this change was lost in merge conflict resolution :.(
Test Plan
almost purely aesthetic change 🌵