Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track tool entry points in receipts #4634

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jun 28, 2024

We need this to power uninstallations!

The latter two commits were reviewed in:

Note this is a breaking change for existing tool installations, but it's in preview and very new. In the future, we'll need a clear upgrade path for tool receipt changes.

@zanieb zanieb added the preview Experimental behavior label Jun 28, 2024
@zanieb zanieb force-pushed the zb/tool-receipt-entry-points branch 2 times, most recently from ca2eec9 to 435500f Compare June 28, 2024 20:07
Comment on lines 81 to 83
[[tool.entrypoints]]
name = "black"
install_path = "[TEMP_DIR]/bin/black"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still honestly on the fence if we should use a mapping with an inline table here instead.

@zanieb zanieb marked this pull request as ready for review June 28, 2024 20:09
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

zanieb added a commit that referenced this pull request Jun 29, 2024
As #4324 did for lock files, updates
the tool receipts to use portable paths. This resolves CI failures on
Windows in #4634 where the toml string literal type changes depending on
the platform.
zanieb added a commit that referenced this pull request Jun 29, 2024
As #4324 did for lock files, updates
the tool receipts to use portable paths. This resolves CI failures on
Windows in #4634 where the toml string literal type changes depending on
the platform.
As #4324 did for lock files, updates
the tool receipts to use portable paths. This resolves CI failures on
Windows in #4634 where the toml string literal type changes depending on
the platform.
@zanieb zanieb force-pushed the zb/tool-receipt-entry-points branch from f71f738 to 7410325 Compare June 29, 2024 03:38
@zanieb zanieb merged commit 3a627f3 into main Jun 29, 2024
47 checks passed
@zanieb zanieb deleted the zb/tool-receipt-entry-points branch June 29, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants