-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track tool entry points in receipts #4634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/tool-receipt-entry-points
branch
2 times, most recently
from
June 28, 2024 20:07
ca2eec9
to
435500f
Compare
zanieb
commented
Jun 28, 2024
crates/uv/tests/tool_install.rs
Outdated
Comment on lines
81
to
83
[[tool.entrypoints]] | ||
name = "black" | ||
install_path = "[TEMP_DIR]/bin/black" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still honestly on the fence if we should use a mapping with an inline table here instead.
charliermarsh
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
zanieb
added a commit
that referenced
this pull request
Jun 29, 2024
zanieb
added a commit
that referenced
this pull request
Jun 29, 2024
zanieb
force-pushed
the
zb/tool-receipt-entry-points
branch
from
June 29, 2024 03:38
f71f738
to
7410325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to power uninstallations!
The latter two commits were reviewed in:
toml_edit
for pretty tool receipt formatting #4637Note this is a breaking change for existing tool installations, but it's in preview and very new. In the future, we'll need a clear upgrade path for tool receipt changes.