Use cross-platform paths in tool receipt entry point paths #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/tool-receipt-path-platform
branch
from
919f5b3
to
a656bc5
Compare
|
I'll merge this all downstack into #4634 so we can merge something that passes CI but feel free to review separately. |
charliermarsh
approved these changes
Jun 28, 2024
zanieb
added a commit
that referenced
this pull request
Jun 29, 2024
zanieb
added a commit
that referenced
this pull request
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #4324 did for lock files, updates the tool receipts to use portable paths. This resolves CI failures on Windows in #4634 where the toml string literal type changes depending on the platform.