feat(sequencer): implement bridge/account_last_tx_hash abci query
#1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
proto
joroshiba
approved these changes
Jun 5, 2024
| @@ -64,6 +64,12 @@ impl Info { | |||
| crate::asset::query::allowed_fee_asset_ids_request, | |||
| ) | |||
| .context("invalid path: `asset/allowed_fee_asset_ids`")?; | |||
| query_router | |||
| .insert( | |||
| "bridge/account_last_tx_hash/:address", | |||
There was a problem hiding this comment.
Not blocking here, because this matches existing pattern but I'd prefer to have resource name style path based queries is /resource-type/{id}/sub-resource-type/{id}. In this instance that would be bridge/{address}/last_tx_hash so it's clear who owns what property hierarchically. The last_tx_hash is a property of the address, which is a bridge.
This would apply to all our queries though.
steezeburger
added a commit
that referenced
this pull request
Jun 10, 2024
* main: fix: ignore RUSTSEC-2021-0139 (#1171) chore(sequencer-relayer)!: remove functionality to restrict relaying blocks to only those proposed by a given validator (#1168) chore(metrics): update `metric_name` macro to handle a collection of names (#1163) fix(bridge-withdrawer): skip linting generated contract code (#1172) fix(core, sequencer): prefix removal source non-refund ics20 packet (#1162) chore(docs): add sequencer-relayer doc to specs (#1126) feat(bridge-withdrawer): sync logic (#1165) chore(withdrawer): replace contracts with `astria-bridge-contracts` submodule (#1164) feat(sequencer)!: implement bridge sudo and withdrawer addresses (#1142) feat(sequencer): implement refund to rollup logic upon ics20 transfer refund (#1161) feat(bridge-withdrawer): bridge withdrawer startup (#1160) feat(core, proto)!: add bech32m addresses (#1124) feat(withdrawer): bridged ERC20 token withdrawals (#1149) feat(sequencer-relayer)!: add chain IDs for sequencer and Celestia to config env vars (#1063) test(bridge-withdrawer): add submitter tests (#1133) chore: bump penumbra deps (#1159) feat(sequencer): implement `bridge/account_last_tx_hash` abci query (#1158) fix(withdrawer): use block subscription in batcher; send to destination_chain_address (#1157) fix(withdrawer): update AstriaWithdrawer to check that withdrawal value is sufficient (#1148) chore(ci): build bridge withdrawer images (#1156)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implement
bridge/account_last_tx_hashabci query which returns the last executed tx from the given bridge account.Background
required for the bridge withdrawer's sync logic (or rather, makes it much simpler to implement).
Changes
bridge/account_last_tx_hashabci query which queries the nonconsensus storage for this tx hash given some address.Testing
unit tests
Related Issues
closes #1107