Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt User For Team Name #1329

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Prompt User For Team Name #1329

merged 3 commits into from
Jul 31, 2023

Conversation

aliotta
Copy link
Contributor

@aliotta aliotta commented Jul 31, 2023

Description

  • adds a prompt when user creates a team but does not pass in a team name
  • makes the select user text more generic so it can be used in more flows

🎟 Issue(s)

#1322
#1255

🧪 Functional Testing

built the cli and ran it locally to verify it works as expected for team creation with and without the name passed in.

Screenshot 2023-07-31 at 4 21 21 PM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c2bcc04) 87.17% compared to head (c08292f) 87.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1329   +/-   ##
=======================================
  Coverage   87.17%   87.18%           
=======================================
  Files         114      114           
  Lines       13367    13370    +3     
=======================================
+ Hits        11653    11656    +3     
  Misses       1025     1025           
  Partials      689      689           
Files Changed Coverage Δ
cloud/team/team.go 85.68% <100.00%> (+0.08%) ⬆️
cloud/user/user.go 92.25% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -142,7 +142,7 @@ func SelectUser(users []astrocore.User, workspace bool) (astrocore.User, error)
Header: []string{"#", "FULLNAME", "EMAIL", "ID", roleColumn, "CREATE DATE"},
}

fmt.Println("\nPlease select the user who's role you would like to update:")
fmt.Println("\nPlease select the user:")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user select method is used for more than just updating a users role so this text was misleading. e.g. to add auser to a team this method is invoked.

@aliotta aliotta merged commit 8e385a1 into main Jul 31, 2023
@aliotta aliotta deleted the promptUserForTeamName branch July 31, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants