Fix isort via pre-commit #845
Conversation
feluelle
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro and
pankajkoti
as code owners
| @@ -70,15 +70,13 @@ repos: | |||
| rev: 5.10.1 | |||
| hooks: | |||
| - id: isort | |||
| name: Run isort to sort imports in Python files | |||
| name: Run isort for python-sdk | |||
There was a problem hiding this comment.
@feluelle Any reason we are doing this separately for Python/SQL SDK?
There was a problem hiding this comment.
Good question. I don't know. 🤷 @dimberman could you help us please?
There was a problem hiding this comment.
yeah it doens't need too -- isort work per file basis afaik, so merging them into a single job is fine too
Codecov ReportBase: 93.09% // Head: 93.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
+ Coverage 93.09% 93.10% +0.01%
==========================================
Files 47 47
Lines 2043 2046 +3
Branches 256 256
==========================================
+ Hits 1902 1905 +3
Misses 109 109
Partials 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
What is the current behavior?
Currently, isort via pre-commit is not running correctly over all related files.
What is the new behavior?
It runs properly over all related files.
Does this introduce a breaking change?
No.
Checklist