Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the bucket var in the docs #907

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Move the bucket var in the docs #907

merged 2 commits into from
Sep 26, 2022

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Sep 23, 2022

This will show what values can be put (specifically gs://) in the name at https://astro-sdk-python.readthedocs.io/en/stable/astro/sql/operators/export.html

@kaxil
Copy link
Collaborator Author

kaxil commented Sep 23, 2022

@feluelle Pre-commit hook locally and on CI have a different opinion on isort -- do you know why?

@pankajastro
Copy link
Contributor

pankajastro commented Sep 25, 2022

@feluelle Pre-commit hook locally and on CI have a different opinion on isort -- do you know why?

I can see an open issue PyCQA/isort#1889 in isort repo
some more old discussion PyCQA/isort#1790

@feluelle
Copy link
Member

feluelle commented Sep 26, 2022

It seems you based your branch on an old commit. The changes made by pre-commit.ci are already in main.

Probably before my isort PR #845. 👍

kaxil and others added 2 commits September 26, 2022 12:05
This will show what values can be put (specifically `gs://`) in the name.
@kaxil kaxil merged commit a9b032c into main Sep 26, 2022
@kaxil kaxil deleted the up-example branch September 26, 2022 13:46
utkarsharma2 pushed a commit that referenced this pull request Oct 4, 2022
kaxil added a commit that referenced this pull request Oct 4, 2022
This will show what values can be put (specifically `gs://`) in the name
at
https://astro-sdk-python.readthedocs.io/en/stable/astro/sql/operators/export.html

(cherry picked from commit a9b032c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants