Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove dace module #3162

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Dec 22, 2024

The module was non-functioning due to server changes. A

After some coordination with the DACE team we opted for its removal from astroquery in favour of the dace-query package that they maintain. We are all open for adding back the module to astroquery if/when there is some support for it from the archive or from the community.

@bsipocz bsipocz added the dace label Dec 22, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (ad2e207) to head (fbf55b0).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/dace/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3162      +/-   ##
==========================================
- Coverage   67.54%   67.49%   -0.06%     
==========================================
  Files         233      232       -1     
  Lines       18493    18446      -47     
==========================================
- Hits        12491    12450      -41     
+ Misses       6002     5996       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant