Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove dace module #3162

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ casda

- Support jobs which are in the SUSPENDED state (used when copying data) [#3134]

dace
^^^^

- Module has been removed as it was incompatible with server changes. A
standalone library called dace-query is available to access DACE
data. [#3162]

esa.hubble
^^^^^^^^^^

Expand Down
28 changes: 4 additions & 24 deletions astroquery/dace/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,9 @@
Dace API
--------

:author: Julien Burnier (julien.burnier@unige.ch)
This module has beeen removed due to upstream changes and in favour of the
standalone dace-query package.
"""

from astropy import config as _config


class Conf(_config.ConfigNamespace):
"""
Configuration parameters for `astroquery.dace`.
"""
server = _config.ConfigItem(
['https://dace-api.unige.ch/'],
'Dace')

timeout = _config.ConfigItem(
30,
'Time limit for connecting to DACE server.')


conf = Conf()

from .core import Dace, DaceClass

__all__ = ['Dace', 'DaceClass',
'Conf', 'conf',
]
raise ImportError("The DACE module has been removed from astroquery due to server-side "

Check warning on line 11 in astroquery/dace/__init__.py

View check run for this annotation

Codecov / codecov/patch

astroquery/dace/__init__.py#L11

Added line #L11 was not covered by tests
"changes. Use the standalone dace-query package to access DACE data.")
78 changes: 0 additions & 78 deletions astroquery/dace/core.py

This file was deleted.

Empty file removed astroquery/dace/tests/__init__.py
Empty file.
62 changes: 0 additions & 62 deletions astroquery/dace/tests/data/parameter_list.json

This file was deleted.

9 changes: 0 additions & 9 deletions astroquery/dace/tests/setup_package.py

This file was deleted.

25 changes: 0 additions & 25 deletions astroquery/dace/tests/test_dace.py

This file was deleted.

19 changes: 0 additions & 19 deletions astroquery/dace/tests/test_dace_remote.py

This file was deleted.

52 changes: 0 additions & 52 deletions docs/dace/dace.rst

This file was deleted.

11 changes: 5 additions & 6 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ queries based on coordinates or object names. Some simple examples, using SIMBA
>>> result_table = Simbad.query_object("m1")
>>> result_table.pprint()
main_id ra dec coo_err_maj coo_err_min coo_err_angle coo_wavelength coo_bibcode matched_id
deg deg mas mas deg
deg deg mas mas deg
------- ------- ------- ----------- ----------- ------------- -------------- ------------------- ----------
M 1 83.6324 22.0174 5000.0 5000.0 90 X 2022A&A...661A..38P M 1

Expand All @@ -156,8 +156,8 @@ All query tools allow coordinate-based queries:
>>> r = 5 * u.arcminute
>>> result_table = Simbad.query_region(c, radius=r)
>>> result_table.pprint(show_unit=True, max_width=80, max_lines=5)
main_id ra ... coo_bibcode
deg ...
main_id ra ... coo_bibcode
deg ...
---------------------------- -------------- ... -------------------
ALMA J053514.4142-052220.792 83.8100591667 ... 2023MNRAS.522...56V
... ... ... ...
Expand All @@ -182,7 +182,7 @@ uncomment the relevant configuration item(s), and insert your desired value(s).


.. _astroquery_cache:

Caching
-------

Expand Down Expand Up @@ -222,7 +222,7 @@ Each service's cache is cleared with the ``clear_cache`` function within that se

Astroquery-wide settings
^^^^^^^^^^^^^^^^^^^^^^^^

Whether caching is active and when cached files expire are controlled centrally through the
astroquery ``cache_conf`` module, and shared among all services.
Astroquery uses the Astropy configuration infrastructure, information about
Expand Down Expand Up @@ -255,7 +255,6 @@ The following modules have been completed using a common API:
cadc/cadc.rst
casda/casda.rst
linelists/cdms/cdms.rst
dace/dace.rst
esa/hsa/hsa.rst
esa/hubble/hubble.rst
esa/iso/iso.rst
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ show-response = 1

[tool:pytest]
minversion = 6.0
norecursedirs = build docs/_build astroquery/irsa astroquery/nasa_exoplanet_archive astroquery/ned astroquery/ibe astroquery/irsa_dust astroquery/cds astroquery/sha
norecursedirs = build docs/_build astroquery/irsa astroquery/nasa_exoplanet_archive astroquery/ned astroquery/ibe astroquery/irsa_dust astroquery/cds astroquery/sha astroquery/dace
testpaths = astroquery docs
doctest_plus = enabled
astropy_header = true
Expand Down
Loading