Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failing because astropy 7.0 deprecated "Fits" #1197

Closed
pllim opened this issue Nov 27, 2024 · 3 comments · Fixed by #1200
Closed

CI failing because astropy 7.0 deprecated "Fits" #1197

pllim opened this issue Nov 27, 2024 · 3 comments · Fixed by #1200
Labels

Comments

@pllim
Copy link
Member

pllim commented Nov 27, 2024

Example log: https://github.com/astropy/specutils/actions/runs/12041463576/job/33573385019

Not sure how we missed it during RC testing... 🧐

specutils\tests\test_loaders.py::test_tabular_fits_autowrite -
astropy.utils.exceptions.AstropyDeprecationWarning:
The class "Fits" has been renamed to "FITS" in version 7.0.
The old name is deprecated and may be removed in a future version.
        Use FITS instead.

Blocked by:

@pllim pllim added the bug label Nov 27, 2024
@pllim
Copy link
Member Author

pllim commented Nov 27, 2024

Maybe the bug is here somewhere but I cannot find it at a glance. 🤷‍♀️

https://github.com/astropy/specutils/blob/main/specutils/io/default_loaders/tabular_fits.py

@dhomeier
Copy link
Contributor

dhomeier commented Dec 3, 2024

It's from gwcs https://github.com/astropy/specutils/actions/runs/12138511071/job/33844133922?pr=1199#step:5:220
and fixed in spacetelescope/gwcs#508 but unreleased yet. Thus py312-test-devdeps was already passing.

@pllim
Copy link
Member Author

pllim commented Dec 4, 2024

This is bad. GWCS needs to release.

spacetelescope/gwcs#508 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants