-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify converting units to strings #508
Conversation
The new code also avoids an upcoming deprecation in `astropy` 7.0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 87.28% 87.27% -0.01%
==========================================
Files 22 21 -1
Lines 3821 3811 -10
==========================================
- Hits 3335 3326 -9
+ Misses 486 485 -1 ☔ View full report in Codecov by Sentry. |
If you compare the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and, as an added benefit, it will handle composite units.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This patch needs a release. We are seeing this warning downstream in specutils now on stable deps in CI because astropy 7.0 is already released. 🙏 @WilliamJamieson 🙏 @nden 🙏 |
@pllim We'll have a release soon. |
The new code also avoids an upcoming deprecation in
astropy
7.0, which closes #499