Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify converting units to strings #508

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

eerovaher
Copy link
Contributor

The new code also avoids an upcoming deprecation in astropy 7.0, which closes #499

The new code also avoids an upcoming deprecation in `astropy` 7.0.
@eerovaher eerovaher requested a review from a team as a code owner September 3, 2024 20:17
@mcara mcara assigned mcara and eerovaher and unassigned mcara Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (eb9d316) to head (6862639).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   87.28%   87.27%   -0.01%     
==========================================
  Files          22       21       -1     
  Lines        3821     3811      -10     
==========================================
- Hits         3335     3326       -9     
+ Misses        486      485       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eerovaher
Copy link
Contributor Author

If you compare the py3-dev job results here with the latest run on master you will see that this pull request has resolved 27 warnings.

Copy link
Member

@mcara mcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and, as an added benefit, it will handle composite units.
Thanks!

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nden nden merged commit 8cc50d9 into spacetelescope:master Sep 4, 2024
21 of 25 checks passed
@nden nden added this to the 0.22 milestone Sep 4, 2024
@eerovaher eerovaher deleted the simpler-unit-to-str branch September 4, 2024 14:22
@pllim
Copy link
Contributor

pllim commented Dec 4, 2024

This patch needs a release. We are seeing this warning downstream in specutils now on stable deps in CI because astropy 7.0 is already released. 🙏 @WilliamJamieson 🙏 @nden 🙏

@nden
Copy link
Collaborator

nden commented Dec 4, 2024

@pllim We'll have a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AstropyDeprecationWarning: The class "Fits" has been renamed to "FITS" in version 7.0
4 participants