Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deprecation warnings coming from upstream gwcs package #1200

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Dec 3, 2024

This ignores two deprecation warnings coming from gwcs. I'll open an issue to remind us to un-ignore these once they do a release that fixes them.

Fixes #1197

@rosteen rosteen added testing no-changelog-entry-needed changelog bot directive labels Dec 3, 2024
@rosteen rosteen added this to the v1.x milestone Dec 3, 2024
@pllim
Copy link
Member

pllim commented Dec 3, 2024

Was a test added recently that access remote data but not marked as such?

@pllim
Copy link
Member

pllim commented Dec 3, 2024

@rosteen
Copy link
Contributor Author

rosteen commented Dec 3, 2024

Was a test added recently that access remote data but not marked as such?

Not that I know of 🤔

@pllim
Copy link
Member

pllim commented Dec 3, 2024

Is the latest IERS table is not important for your tests, please consider the offline option. Thanks!

@pllim
Copy link
Member

pllim commented Dec 19, 2024

gwcs release is dragging on. Maybe we should fix the CI here and merge. Are you able to rebase, @rosteen ? 🙏

@rosteen rosteen force-pushed the ignore-gwcs-warning branch from ec00764 to 525645d Compare December 19, 2024 14:38
@pllim
Copy link
Member

pllim commented Dec 19, 2024

Phew at least IERS errors went away.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
Copy link
Member

pllim commented Dec 19, 2024

We can ignore the devdeps failure, looks like Nadia is trying to fix that one at #1204

@pllim pllim merged commit 248f86e into astropy:main Dec 19, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing because astropy 7.0 deprecated "Fits"
2 participants