Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test envs now that python 3.12 is released #1089

Closed
wants to merge 7 commits into from

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Oct 3, 2023

Updates our OS tests to all use python 3.12 and adds a test to keep checking against 3.11.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5098f23) 70.73% compared to head (4856f9d) 70.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1089   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files          64       64           
  Lines        4483     4483           
=======================================
  Hits         3171     3171           
  Misses       1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, don't you need quotes around python for python>=3.10 ?

python: '3.11'

@rosteen
Copy link
Contributor Author

rosteen commented Oct 26, 2023

Hmm, don't you need quotes around python for python>=3.10 ?

I thought the problem was specific to 3.10, since parsing that as a float would make it 3.1, whereas 3.11 would keep the full value.

@pllim
Copy link
Member

pllim commented Oct 26, 2023

oldest deps failure is caused by #1091

devdeps failure is caused by something preventing scipy from upgrading to dev version: numpy==2.0.0.dev0 vs scipy==1.11.3 (while we're at it, looks like matplotlib also failed to upgrade, which is very annoying)

@pllim
Copy link
Member

pllim commented Nov 9, 2023

I fixed oldest-deps, so you should rebase if you still want to pursue this.

@rosteen rosteen deleted the update-312-test branch November 22, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants