TST: Fix devdeps and clean up matrix #1111
Conversation
job because it is upgrading numpy but we do not want that to happen.
* Replace tmpdir with tmp_path * Fix path construction * Removed unused tmp_path Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
and stuff
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
+ Coverage 70.74% 70.80% +0.06%
==========================================
Files 64 64
Lines 4484 4484
==========================================
+ Hits 3172 3175 +3
+ Misses 1312 1309 -3 ☔ View full report in Codecov by Sentry. |
|
I see numpy 1.x vs 2.x ABI warning and dateutil deprecation warning in the devdeps log here but somehow it did not fail pytest even though we are turning warnings into exceptions. I think maybe it is because in devdeps, we install quite a few things from source and some of those might be emitting these warnings, not us, so maybe it is okay to ignore as long as CI is green here. |
pllim
requested review from
eteq,
rosteen,
nmearl and
keflavich
as code owners
| @@ -28,11 +27,7 @@ install_requires = | |||
| [options.extras_require] | |||
| test = | |||
| pytest-astropy | |||
| pytest-cov | |||
| tox | |||
There was a problem hiding this comment.
I just added tox here so that people can run pip install -e .[test] locally and get everything they need to check their code locally before opening a PR, e.g. running tox -e codestyle (or any of the other tests via tox). I would prefer to keep this in.
There was a problem hiding this comment.
Okay but you don't really need tox to do that. You can run flake8 specutils locally and it is the same check.
|
Thanks! |
* TST: Pin casa-formats-io in oldest-deps job because it is upgrading numpy but we do not want that to happen. * Replace tmpdir with tmp_path (astropy#1095) * Replace tmpdir with tmp_path * Fix path construction * Removed unused tmp_path Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> * Fix devdeps and clean up matrix and stuff * Use astropy>=5.3 for doctest * Add tox back in --------- Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com> Co-authored-by: Ricky O'Steen <rosteen@stsci.edu>
Fix devdeps job and clean up the testing infrastructure in general (some outdated stuff and unnecessary stuff from copy-paste).
xref astropy/astropy#15638
Close #1089
Fix #1036