add unit tests #56
Merged
add unit tests #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested changes
Aug 28, 2019
library/package.json
Outdated
| @@ -50,7 +50,7 @@ | |||
| "postpack": "rm -rf ./README.md && rm -rf ./LICENSE" | |||
| }, | |||
| "dependencies": { | |||
| "asyncapi-parser": "^0.7.0", | |||
| "asyncapi-parser": "^0.7.1", | |||
There was a problem hiding this comment.
Already is 0.8.2 version.
library/src/helpers/parser.ts
Outdated
| ) => Promise<AsyncApi>; | ||
|
|
||
| export default class Parser { | ||
| private parseDocument: ParseDocument; |
There was a problem hiding this comment.
This is the tricky one we have a class that already has parse method.
I see two solutions:
- rename class method from
parsetodothan renameparseDocumenttoparseandparseDoumentFromURLtoparseURL - rename from
parseDocumenttoparseFn(or similar) andparseDoumentFromURtoparseURLFn
There was a problem hiding this comment.
- rename to
parseSchema{FromURL}
| type ParserOptions = AsyncApiProps['parserOptions']; | ||
|
|
||
| import { UNSUPPORTED_SCHEMA_VERSION } from '../constants'; | ||
| type ParseDocument = ( |
There was a problem hiding this comment.
ParseSchema and ParseSchemaFromURL
| err.parsedJSON && | ||
| !this.isCorrectSchemaVersion(err.parsedJSON.asyncapi) | ||
| ) { | ||
| if (err.parsedJSON && err.parsedJSON.asyncapi.startsWith('1')) { |
There was a problem hiding this comment.
Please revert this to isCorrectSchemaVersion function.
There was a problem hiding this comment.
isCorrectSchemaVersiononly checks the first character e.g.-1.2.3is not a correct schema version but the function would returntrue- it is oneliner used just in this place
magicmatatjahu
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
kyma-project/console#684