Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force object type for message trait's headers #102

Merged

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Sep 23, 2021

Description

Force object type for message trait's headers in 2.0.0, 2.1.0 and 2.2.0 versions.

PR for 2.3.0 #155

Related issue(s)
Fixes #82

@magicmatatjahu magicmatatjahu added the bug Something isn't working label Sep 23, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member

@derberg @fmvilas @magicmatatjahu any progress here?

@magicmatatjahu
Copy link
Member Author

@jonaslagoni You dug up some dead PR 😅 I'll make an update for 2.2 and a separate PR for 2.3.

@magicmatatjahu
Copy link
Member Author

@derberg Could you check?

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for @derberg.

@fmvilas
Copy link
Member

fmvilas commented Mar 3, 2022

/dnm

@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member

fmvilas commented Mar 7, 2022

@magicmatatjahu feel free to merge it yourself :)

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 5df8873 into asyncapi:master Mar 7, 2022
@magicmatatjahu magicmatatjahu deleted the fix-message-trait-headers branch March 7, 2022 12:22
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate object type for the headers in the message trait
6 participants