Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force object type for message trait's headers #155

Merged
merged 1 commit into from
Jan 24, 2022
Merged

fix: force object type for message trait's headers #155

merged 1 commit into from
Jan 24, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

Force object type for message trait's headers.

Related issue(s)
Part of #82

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu mentioned this pull request Jan 18, 2022
Merged
@dalelane dalelane mentioned this pull request Jan 23, 2022
Closed
39 tasks
@dalelane
Copy link
Collaborator

@derberg @fmvilas Are you happy for this to go into 2.3? If so, are you able to review and merge please?

fmvilas
fmvilas approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good to me as the spec already says it MUST be of type "object" 👍

@fmvilas
Copy link
Member

fmvilas commented Jan 24, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit b2f52b1 into asyncapi:2022-01-release Jan 24, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.13.0-2022-01-release.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@magicmatatjahu magicmatatjahu deleted the 2022-01/fix-message-trait-headers branch January 24, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas approved these changes

Assignees
No one assigned
Labels
ready-to-merge released on @2022-01-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@magicmatatjahu @dalelane @fmvilas @asyncapi-bot @derberg