-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add script to add new version #181
Conversation
I have no idea what the sonar rules are called, so I don't know how to disable them. I did add a simple input check to see if it matches semver version, so there should be no unsafe OS commands possible. For the codesmell, cant really do anything about it, as this is the regex suggested on the semver site. |
@jonaslagoni sonar is complaining about script that runs only in CI, so just ignore it entirely for sonar I have other problem with this PR, you make many changes that come from the fact that you create a PR not from |
Pr is up #187 |
Is this something we have to do from the platform itself or? 🤔 |
@jonaslagoni no, we always tend to do it with config files in repo, like before...or I didn't get something btw, you need to update PR with latest |
I have.
Problem is, as I think it was last time. I dont have access to the configuration "keys" that is needed to disable the check 🤔 |
sorry, I thought you are aware of something like https://github.com/asyncapi/glee/blob/master/.sonarcloud.properties so you can exclude entire script from all the rules oko, so now we have a script, but how is it triggered? |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Gonna redo this once #184 is merged. |
Damn, when targeted branches are removed, remaining PRs are closed as well with no way to retarget them... |
Description
As discussed in #128 this PR adds a new script to make it more maintainable instead of one long shell script.