fix: nexti18nSetup for OG tags error #3111

sambhavgupta0705 · 2024-07-23T11:11:59Z

This PR fixes the OG tag error

netlify · 2024-07-23T11:12:15Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`d2740c4`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/66db50d57dc40b0008e205f2
😎 Deploy Preview	https://deploy-preview-3111--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

asyncapi-bot · 2024-07-23T11:16:20Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	43
🟢 Accessibility	98
🟢 Best practices	92
🟢 SEO	100
🔴 PWA	33

Lighthouse ran on https://deploy-preview-3111--asyncapi-website.netlify.app/

sambhavgupta0705 · 2024-07-23T11:33:32Z

@aeworxet This is the draft PR for the issue
@akshatnema @anshgoyalevil PTAL

aeworxet · 2024-07-23T12:31:13Z

@asyncapi/bounty_team

akshatnema · 2024-07-29T09:11:04Z

components/newsroom/FeaturedBlogPost.tsx

@@ -43,7 +43,7 @@ export default function FeaturedBlogPost({ post, className = '' }: FeaturedBlogP
  return (
    <div className={`rounded-lg ${className}`}>
      <article className='h-full rounded-lg'>
-        <Link href={post.slug}>
+        <div >


Why do we need this change?

The Link was causing the hydration to fail (see screenshot)

The reason behind the hydration error was that we are nesting a <Link> tag within <Link> tag.

The first <Link> Tag:

website/components/newsroom/FeaturedBlogPost.tsx

Line 46 in 6159306

<Link href={post.slug}>

The second (nested) <Link> Tag:

website/components/newsroom/FeaturedBlogPost.tsx

Lines 69 to 78 in 6159306

<Link href={post.slug}>

<span className='block' data-testid='FeaturedBlog-title'>

<Heading level={HeadingLevel.h3} typeStyle={HeadingTypeStyle.smSemibold} className='mt-2'>

{post.title}

</Heading>

<Paragraph typeStyle={ParagraphTypeStyle.sm} className='mt-3'>

<TextTruncate element='span' line={2} text={post.excerpt} />

</Paragraph>

</span>

</Link>

Both of these links has the same target (i.e. post.slug). So removing the outer Ling tag should not have any side effects.

Suggested change

<div >

<div>

akshatnema · 2024-07-29T09:11:46Z

markdown/blog/websocket-part2.md

@@ -165,7 +165,7 @@ servers:
      The API client must request an authentication "token" via the following REST API endpoint "GetWebSocketsToken" to connect to WebSockets Private endpoints. For more details, read https://support.kraken.com/hc/en-us/articles/360034437672-How-to-retrieve-a-WebSocket-authentication-token-Example-code-in-Python-3

      The resulting token must be provided in the "token" field of any new private WebSocket feed subscription: 
-      ```
+


Why this Codeblock is removed?

Please Go to the production url https://www.asyncapi.com/blog/websocket-part2
You will see the following error message in the blog content.

Application error: a client-side exception has occurred (see the browser console for more information).

After Fixing the i18n configuration, the most part of the site started to render on the server. So any inconsistency in the markdown can be caught during the build.

When we kept the codeblocks, the following error was occuring during build

But we show that code as part of codeblock. Don't we have any solution for it?

It's giving a weird response inside CodeBlock.

Sambhav has pushed solution in this commit. PTAL. Thanks.

akshatnema · 2024-07-29T09:17:18Z

package.json

@@ -90,7 +92,7 @@
    "react-dom": "^18",
    "react-ga": "^3.3.1",
    "react-gtm-module": "^2.0.11",
-    "react-i18next": "^14.0.5",
+    "react-i18next": "^14.1.3",


Do we still need this library?

@sambhavgupta0705 We should uninstall the react-i18next library, i don't think we need it anymore.

Yes I will fix this one

akshatnema · 2024-07-29T09:33:51Z

pages/[lang]/tools/cli.tsx

+// /**
+//  * @description Get the language for the CLI page.
+//  * @returns { paths: { params: { lang: string } }[]; fallback: boolean }
+//  */


Suggested change

// /**

// * @description Get the language for the CLI page.

// * @returns { paths: { params: { lang: string } }[]; fallback: boolean }

// */

Remove this comment.

akshatnema · 2024-07-29T09:41:13Z

pages/_app.tsx

      <AppContext.Provider value={{ path: router.asPath }}>
+        {/* <MDXProvider components={mdxComponents}> */}


Why MDXProvider is commented?

We are now using the MDX provider for the next.js instead of the provider from the @mdx-js/react library.
you can find the configuration of the new next.js MDX Provider here.

When we kept provider from @mdx-js/react. We ran into several MDX errors during the build. (see screenshot)

@sambhavgupta0705 I think we should delete the commented lines

So, are we now changing the whole MDX rendering part as well?

Yes correct.
Please note that, it does not affect end result. Rendered MDX will look exactly as it did with the previous MDXProvider.

Ogtags package fix

… into ogtags

sambhavgupta0705 · 2024-09-04T10:24:13Z

@akshatnema ptal

Signed-off-by: Sambhav Gupta <sambhavgupta0705@gmail.com>

… into ogtags

Signed-off-by: Sambhav Gupta <sambhavgupta0705@gmail.com>

akshatnema · 2024-09-07T06:37:10Z

Merging this without docs approval because MD file changes are not changing any doc content. Only a few markdown syntax changes are there.

sambhavgupta0705 · 2024-09-07T06:44:46Z

Finally Merged @aeworxet 🚀

initial commit

f1a57a0

sambhavgupta0705 requested review from thulieblack, quetzalliwrites, asyncapi-bot-eve, derberg, akshatnema, magicmatatjahu, anshgoyalevil and Mayaleeeee as code owners July 23, 2024 11:12

asyncapi-bot requested review from BhaswatiRoy, J0SAL, TRohit20 and VaishnaviNandakumar July 23, 2024 11:12

Merge branch 'master' into ogtags

69c43f2

sambhavgupta0705 added 2 commits July 23, 2024 16:53

fixes

960d694

package.json changes

10a2516

fixing local host url

6f8e0fb

asyncapi-bot added the bounty AsyncAPI Bounty program related label label Jul 23, 2024

sambhavgupta0705 added 6 commits July 23, 2024 18:25

foixed caseStudies

e70371e

home page fix

ec0864a

fixed GH button

679f6bc

fixed linting

85485e9

fixed linting

66debb3

fixed githubButton

96d4691

sambhavgupta0705 mentioned this pull request Jul 25, 2024

fix(docs issue): undefined errors while rendering in docs/tools #3117

Closed

akshatnema requested changes Jul 29, 2024

View reviewed changes

JeelRajodiya and others added 3 commits August 31, 2024 00:20

Merge branch 'asyncapi:master' into ogtags-package-fix

01fcb80

Merge pull request #2 from sambhavgupta0705/ogtags-package-fix

3bf1b18

Ogtags package fix

fixed lint errors

24233a8

This was referenced Aug 31, 2024

fix: fixing rendering errors of glee docs asyncapi/glee#839

Merged

fix: fixed rendering issue of website asyncapi/cli#1504

Merged

sambhavgupta0705 and others added 5 commits August 31, 2024 22:12

fix

e879cd3

Merge branch 'master' into ogtags

451f48d

temporary commit

671b0ba

temporary commit

3bbbe4f

temporary commit

a3d0dbe

sambhavgupta0705 mentioned this pull request Sep 3, 2024

fix: rendering error of the website asyncapi/cli#1507

Merged

sambhavgupta0705 and others added 7 commits September 3, 2024 11:33

revert breaking changes

81fce4f

Merge branch 'master' into ogtags

ff6c0b4

space fixes

5d43180

Merge branch 'master' into ogtags

8b88156

test

428bf11

Merge branch 'ogtags' of github.com:sambhavgupta0705/asyncapi_website…

420ec89

… into ogtags

test

6bc1848

Merge branch 'master' into ogtags

1f20cba

sambhavgupta0705 requested a review from akshatnema September 4, 2024 10:25

sambhavgupta0705 and others added 5 commits September 5, 2024 22:45

Merge branch 'master' into ogtags

a1e0906

featured blog post file changes

62c1c2d

Signed-off-by: Sambhav Gupta <sambhavgupta0705@gmail.com>

Merge branch 'ogtags' of github.com:sambhavgupta0705/asyncapi_website…

bf1b1ee

… into ogtags

Merge branch 'master' into ogtags

cff22dd

lint error fix

d2740c4

Signed-off-by: Sambhav Gupta <sambhavgupta0705@gmail.com>

akshatnema approved these changes Sep 7, 2024

View reviewed changes

akshatnema merged commit 4e36482 into asyncapi:master Sep 7, 2024
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: nexti18nSetup for OG tags error #3111

fix: nexti18nSetup for OG tags error #3111

sambhavgupta0705 commented Jul 23, 2024

netlify bot commented Jul 23, 2024 •

edited

Loading

asyncapi-bot commented Jul 23, 2024 •

edited

Loading

sambhavgupta0705 commented Jul 23, 2024

aeworxet commented Jul 23, 2024

akshatnema Jul 29, 2024

JeelRajodiya Jul 29, 2024 •

edited

Loading

akshatnema Jul 30, 2024

akshatnema Jul 29, 2024

JeelRajodiya Jul 29, 2024

akshatnema Jul 30, 2024

akshatnema Jul 30, 2024

JeelRajodiya Aug 9, 2024 •

edited

Loading

akshatnema Jul 29, 2024

JeelRajodiya Jul 29, 2024 •

edited

Loading

sambhavgupta0705 Jul 30, 2024

akshatnema Jul 29, 2024

akshatnema Jul 29, 2024

JeelRajodiya Jul 29, 2024

akshatnema Jul 30, 2024

JeelRajodiya Jul 30, 2024

sambhavgupta0705 commented Sep 4, 2024

akshatnema commented Sep 7, 2024

sambhavgupta0705 commented Sep 7, 2024 •

edited

Loading

	<Link href={post.slug}>
	<span className='block' data-testid='FeaturedBlog-title'>
	<Heading level={HeadingLevel.h3} typeStyle={HeadingTypeStyle.smSemibold} className='mt-2'>
	{post.title}
	</Heading>
	<Paragraph typeStyle={ParagraphTypeStyle.sm} className='mt-3'>
	<TextTruncate element='span' line={2} text={post.excerpt} />
	</Paragraph>
	</span>
	</Link>

		<AppContext.Provider value={{ path: router.asPath }}>
		{/* <MDXProvider components={mdxComponents}> */}

fix: nexti18nSetup for OG tags error #3111

fix: nexti18nSetup for OG tags error #3111

Conversation

sambhavgupta0705 commented Jul 23, 2024

netlify bot commented Jul 23, 2024 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

asyncapi-bot commented Jul 23, 2024 • edited Loading

sambhavgupta0705 commented Jul 23, 2024

aeworxet commented Jul 23, 2024

Choose a reason for hiding this comment

JeelRajodiya Jul 29, 2024 • edited Loading

Choose a reason for hiding this comment

The first <Link> Tag:

The second (nested) <Link> Tag:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JeelRajodiya Aug 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JeelRajodiya Jul 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sambhavgupta0705 commented Sep 4, 2024

akshatnema commented Sep 7, 2024

sambhavgupta0705 commented Sep 7, 2024 • edited Loading

netlify bot commented Jul 23, 2024 •

edited

Loading

asyncapi-bot commented Jul 23, 2024 •

edited

Loading

JeelRajodiya Jul 29, 2024 •

edited

Loading

The first `<Link>` Tag:

The second (nested) `<Link>` Tag:

JeelRajodiya Aug 9, 2024 •

edited

Loading

JeelRajodiya Jul 29, 2024 •

edited

Loading

sambhavgupta0705 commented Sep 7, 2024 •

edited

Loading