Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs issue): undefined errors while rendering in docs/tools #3117

Closed

Conversation

Saumya40-codes
Copy link
Contributor

Description

Currently this page and this are throwing errors

image

image

The main issue was in docs {token} and {contextName} keywords are used as it and then being rendered which causes javascript to be identified it as a value (thus it is undefined)

Using escape character fixes this
image
image

Related issue(s)

Resolves #3115

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 92bcf43
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66a2721e35cc13000840bc69
😎 Deploy Preview https://deploy-preview-3117--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Saumya40-codes Saumya40-codes changed the title fix(docs issue): undefined errors while rendering fix(docs issue): undefined errors while rendering in docs/tools Jul 25, 2024
@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 37
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-3117--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

@Saumya40-codes I think this PR will fix this one
#3111

@Saumya40-codes
Copy link
Contributor Author

Saumya40-codes commented Jul 25, 2024

@Saumya40-codes I think this PR will fix this one #3111

Oh I didn't look up for this there!
It will be fixing this.

I'll close this pr/issue!!

@Saumya40-codes Saumya40-codes deleted the docs-cli-contextname branch July 26, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs Bug 🐞 report]: contextName is not defined while rendering
3 participants