Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for INI config file parsing #333

Closed
atc0005 opened this issue Nov 21, 2022 · 0 comments · Fixed by #344
Closed

Add tests for INI config file parsing #333

atc0005 opened this issue Nov 21, 2022 · 0 comments · Fixed by #344
Labels
App: list-emails auth/basic auth/oauth2 config enhancement New feature or request tests
Milestone
v0.6.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Nov 21, 2022

This is particularly important with the changes being applied for OAuth2 support.

At least two high-level tests:

  • parse basic authentication example config file
  • parse oauth2 authentication example config file
@atc0005 atc0005 modified the milestones: v0.5.0, Next Feature Release Nov 21, 2022
@atc0005 atc0005 mentioned this issue Nov 25, 2022
Closed
atc0005 added a commit that referenced this issue Nov 25, 2022
@atc0005
Rename Config.loadINIConfig method
bf7edf5 
Rename to `parseConfigFile` to better describe purpose.

refs GH-333
atc0005 added a commit that referenced this issue Nov 25, 2022
@atc0005
Add tests for INI config file loading/parsing
0548d3d 
- Rename `Config.loadINIConfig` method to `parseConfigFile`
  to better describe purpose
- Add new tests to exercise config file loading/validation logic
  - TestParseExampleConfigFiles
  - TestValidateBasicAuthExampleConfigFile
  - TestValidateOAuth2ExampleConfigFile

refs GH-333
atc0005 added a commit that referenced this issue Nov 25, 2022
@atc0005
Add tests for INI config file loading/parsing
3bbe841 
- Rename `Config.loadINIConfig` method to `parseConfigFile`
  to better describe purpose
- Add new tests to exercise config file loading/validation logic
  - TestParseExampleConfigFiles
  - TestValidateBasicAuthExampleConfigFile
  - TestValidateOAuth2ExampleConfigFile

refs GH-333
@atc0005 atc0005 mentioned this issue Nov 25, 2022
Merged
atc0005 added a commit that referenced this issue Nov 26, 2022
@atc0005
Remove log file and directory after tests finish
c9674ce 
Explicitly create log file in a testing package created temporary
directory for that purpose and close the log file as part of test
cleanup.

This prevents leaving empty log files (and the log directory)
laying about after running tests specific to the `list-emails`
application.

refs GH-333
@atc0005 atc0005 mentioned this issue Nov 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
App: list-emails auth/basic auth/oauth2 config enhancement New feature or request tests
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Add tests for INI config file parsing atc0005/check-mail
1 participant
@atc0005