Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom flagset in order to better handle flag issues #339

Closed
atc0005 opened this issue Nov 25, 2022 · 0 comments · Fixed by #343
Closed

Implement custom flagset in order to better handle flag issues #339

atc0005 opened this issue Nov 25, 2022 · 0 comments · Fixed by #343
Assignees
Labels
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Nov 25, 2022

During implementation of new tests for GH-333 I intentionally referenced an invalid flag name and the config initialization step didn't halt as expected. Further testing showed that flag parsing doesn't halt unless a custom flagset is used.

@atc0005 atc0005 added enhancement New feature or request flag tests labels Nov 25, 2022
@atc0005 atc0005 added this to the Next Feature Release milestone Nov 25, 2022
@atc0005 atc0005 self-assigned this Nov 25, 2022
atc0005 added a commit that referenced this issue Nov 25, 2022
- Implement custom flagset to provide better handling of flag
  parsing issues
- Implement custom Usage & Help logic to override default help
  output sink of stderr to allow Nagios XI and similar systems
  to read help text from stdout. This allows those systems to
  display help text for plugins in this project while a
  sysadmin is configuring a command definition

refs GH-339
refs GH-340
@atc0005 atc0005 added the config label Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant