Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the directory contains Chinese file names, alignment errors will occur #416

Closed
4 tasks
Chdy opened this issue Nov 19, 2020 · 3 comments · Fixed by #419
Closed
4 tasks

If the directory contains Chinese file names, alignment errors will occur #416

Chdy opened this issue Nov 19, 2020 · 3 comments · Fixed by #419
Labels

Comments

@Chdy
Copy link

Chdy commented Nov 19, 2020

Description

Thanks for opening this issue. Add a brief description of what this issue is, and how to recreate it. Do tag the relevant issue(s) and PR(s) below. If required, add some screenshot(s) to showcase the issue.

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of issue :
    • Installation
    • Font-related
    • Feature request
    • [*] Bug in existing feature
    • Developer mode : Code quality / Tests / Documentation

A8C92690-FEDF-4AFF-917E-CFB94EEB56CC

For each line, if Chinese appears on the left, then there will be an incorrect alignment on the right

@avdv
Copy link
Collaborator

avdv commented Nov 19, 2020

Could you just copy and paste the output from your terminal please?! A screenshot is usually not helpful when trying to reproduce am issue.

@Chdy
Copy link
Author

Chdy commented Nov 20, 2020

I don’t know why multiple spaces are combined into one in github. I copied the output into a file, hoping to display normally
error.txt

@avdv
Copy link
Collaborator

avdv commented Nov 21, 2020

The problem seems to be the width of the characters in your font. The kanji simply take more space than the roman characters, as it's not a truly mono-space font I guess.

GNU ls seems to circumvent this problem by using tabs to display the file names.

avdv added a commit to avdv/colorls that referenced this issue Nov 21, 2020
avdv added a commit to avdv/colorls that referenced this issue Nov 21, 2020
@avdv avdv closed this as completed in #419 Nov 23, 2020
@avdv avdv added the bug label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants