Take display width of characters into account #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 89.23% 89.25% +0.02%
==========================================
Files 8 8
Lines 511 512 +1
==========================================
+ Hits 456 457 +1
Misses 55 55
Continue to review full report at Codecov.
|
|
That does not really solve the problem, we need to use the https://github.com/janlelis/unicode-display_width gem |
Updates the requirements on [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases) - [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-performance@v1.8.0...v1.9.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Some Unicode characters, e.g. chinese, consume more space when displayed on a terminal than a single roman character. To avoid alignment issues, try to determine the width using the unicode-display_width gem.
avdv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Special characters (such as chinese) have a bigger width in a terminal, so the alignment of columns breaks. We need to determine the display width of the characters to compute the proper padding needed for the next column.