Fix git processing #337
Merged
Fix git processing #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` .rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout ```
git does not report any status for empty directories, and it also does not report any status for directories without any modified, untracked or ignored files. To correctly show the status, we need to check whether the directory is empty if git did not report any status codes. When empty, show it as "not interesting", otherwise the "no changes" green check mark is shown. Note, I am specifically not using the untracked marker, as that would mean there is some interesting file inside the directory which could be added. Fixes athityakumar#334.
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 89.24% 89.06% -0.19%
==========================================
Files 8 8
Lines 493 494 +1
==========================================
Hits 440 440
- Misses 53 54 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description