Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git processing #337

Merged
merged 3 commits into from
Jan 24, 2020
Merged

Fix git processing #337

merged 3 commits into from
Jan 24, 2020

Commits on Jan 20, 2020

  1. Fix rubocop warning, move LineLength into Layout namespace

    ```
    .rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout
    ```
    avdv committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    b43a476 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. Fix git output showing no changes

    avdv committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    d0244c2 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Correct git status for directories without changes

    git does not report any status for empty directories, and it also does not
    report any status for directories without any modified, untracked or ignored
    files.
    
    To correctly show the status, we need to check whether the directory is empty if
    git did not report any status codes. When empty, show it as "not interesting",
    otherwise the "no changes" green check mark is shown.
    
    Note, I am specifically not using the untracked marker, as that would mean there
    is some interesting file inside the directory which could be added.
    
    Fixes athityakumar#334.
    avdv committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    fb39a9d View commit details
    Browse the repository at this point in the history