Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to install font for hyperjs users #375

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

kartsims
Copy link
Contributor

Added some instructions for hyperjs users as I spent 2 minutes looking for the solution :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files           8        8           
  Lines         501      501           
=======================================
  Hits          441      441           
  Misses         60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95aee85...3f4ca08. Read the comment docs.

@avdv
Copy link
Collaborator

avdv commented Sep 7, 2020

Hi @kartsims,

thanks for you PR and sorry for not responding for so long!

Are you sure that the instructions are correct? AFAICS, the name of the font should be "Hack Nerd Font", instead of "Hack Regular Nerd". If I use the latter, the system chooses an arbitrary font which supports the icons used by colorls, and those icons appear too small. It is the same behavior I see if I do not list any Nerd font in fontFamily at all.

@kartsims
Copy link
Contributor Author

kartsims commented Sep 8, 2020

You are correct, my bad!

README.md Show resolved Hide resolved
@avdv avdv changed the title added instructions to install font for hyperjs users Add instructions to install font for hyperjs users Sep 8, 2020
@avdv avdv merged commit f20d5da into athityakumar:master Sep 8, 2020
@avdv
Copy link
Collaborator

avdv commented Sep 8, 2020

Thanks @kartsims !

avdv pushed a commit to avdv/colorls that referenced this pull request Sep 26, 2020
avdv pushed a commit to avdv/colorls that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants