Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fontFamily for HyperJS users in instructions #396

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Updated fontFamily for HyperJS users in instructions #396

merged 1 commit into from
Sep 20, 2020

Conversation

DasCodes
Copy link
Contributor

@DasCodes DasCodes commented Sep 20, 2020

The font family in #2 installation instruction for HyperJS users should be "Hack Nerd Font" not "Hack Regular Nerd".

  • Type of change :
    • Addition or Improvement of documentation

The font family in #2 installation instruction for `HyperJS` users should be `"Hack Nerd Font"` not `"Hack Regular Nerd"`.
@codecov-commenter
Copy link

Codecov Report

Merging #396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files           8        8           
  Lines         501      501           
=======================================
  Hits          444      444           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dae294...c676748. Read the comment docs.

@avdv
Copy link
Collaborator

avdv commented Sep 20, 2020

Somehow I failed to apply the suggested change in PR 375: #375 (comment) 🤔

Thanks!

@avdv avdv merged commit 0265519 into athityakumar:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants