Official windows support #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 88.88% 89.18% +0.30%
==========================================
Files 8 8
Lines 513 518 +5
==========================================
+ Hits 456 462 +6
+ Misses 57 56 -1
Continue to review full report at Codecov.
|
avdv
force-pushed
the
fix-windows
branch
2 times, most recently
from
325c58e
to
3e88991
Compare
* call `bundle clean` before caching * explicitely specify path for `bundle install` * create a `--msys2--` file as a marker to skip msys2 & ridk install
On Windows, MRI Ruby uses the `FindFirstFileW` et. al. kind of functions with wide character paths and constantly converts from multi-byte to wide character encoding back and forth when calling any methods on `File` or `Dir`. This means that when using `Encoding::ASCII_8BIT` for reading directory entries, that this does not round trip properly, if a file name contains unicode characters. That is because Ruby assumes the path string is encoded in Windows Codepage 1252[1]. * skip symlink test if files were checked out from git as textual symlinks on Windows * use UTF-8 encoding on Windows, since this properly round-trips between multi-byte and wide character encoding * travis: windows job no longer is allowed to fail [1]: https://github.com/ruby/ruby/blob/946cd6c5348d7dd12ecc41e79c3ca9803d2ca7f0/win32/file.c#L131-L134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows build on Travis fails. Check why and fix this.