Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Remove meta.tag.any.html #172

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Remove meta.tag.any.html #172

merged 1 commit into from
Sep 21, 2017

Conversation

winstliu
Copy link
Contributor

@winstliu winstliu commented Sep 21, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

meta.tag.any.html is a useless pattern that only matches when there is no space between the begin and end tags. It is not used by autocomplete, and meta.tag.other.html matches that pattern just fine. I have also replaced all the other .any's with the actual tag name, meaning meta.tag.structure.any.html is now meta.tag.structure.div.html (or equivalent). Finally, snippets are now prevented from showing up when against an opening tag.

Essentially, it is a lighter version of #93.

Alternate Designs

None.

Benefits

Grammar cleanup and finer-grained scopes.

Possible Drawbacks

This will require autocomplete-html to recognize the new meta scopes before it can be merged.

Applicable Issues

Fixes #25
Supersedes and closes #93

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script tag classes change depending on indent
1 participant