This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large PR, so I'll try to explain it as best as possible:
meta.tag.any.html
has been removed. This pattern really made absolutely no sense since it was trying to match<hello></hello>
, but withmeta.scope.between-tag-pair.html
shoved between the<
and/
. It was also trying to match attributes in the text content itself, between the two tags. Finally, since it was the very first pattern, it was overriding other patterns such as thescript
ones when they were on a single line.meta.tag.other.html
is basically the replacement formeta.tag.any.html
, but without its downfalls. It's a catch-all for any tag that wasn't previously matched.invalid.illegal.out-of-order-tag.html
(such as<abc><def></abc></def>
).p
,br
,area
, and more.punctuation.definition.tag.begin.html
(.comment
for comments) and.end
selectors. Previously, it was inconsistent and some had them, while others only hadpunctuation.definition.tag.html
.Note: Please merge after #90. That PR changed around the script tags and I'd like to make sure that they're consistent with the changes made in this PR before merging this one.
Fixes #25