"Enterprise" persistence for Windows Credentials

[jakobvogel]

This PR revises password storage on Microsoft Windows to claim "Enterprise" persistence instead of "Local Machine" persistence. This allows passwords to be roamed across enterprise networks, i.e. a certain single user will find his/her stored passwords when logging into different machines of the same network, should the administrator enable this.

This change should be reverse-compatible, as the credential manager will continue to find "old" entries with "Local Machine" persistence as well.

This PR closes #122.

Before PR

After PR

[jakobvogel]

Interestingly enough, exactly the same issue was fixed a couple of days ago in a very similar library: frankosterfeld/qtkeychain#121

[shiftkey]

cc @daviwil for :eyes

[jakobvogel]

Any news here? :)

[bkostjens]

Hello, in the latest version of keytar (4.4.1) the this is still not implemented?

keytar_win.cc has still cred.Persist = CRED_PERSIST_LOCAL_MACHINE;

For us this is also a problem as we want to deploy keytar in an enterprise environment. Any news?

[bkostjens]

I created a new issue for this:

#168

[jakobvogel]

No, it is not implemented. We decided to fork the project and fix it ourselves there. Turned out to be simpler than waiting for a code review here, despite the extra work.

[bkostjens]

Thanks for responding. The big problem for me is that Im on macOS, but need to compile for windows as well. When forking I miss the precompiled packages, im not sure how to handle this?

[jakobvogel]

We’re also developing on macOS, but for the purpose of building the Windows variant, we run a separate Windows machine. We need the latter for code signing anyways. Our builds are just local at this time, though. 😔 I would definitely prefer to have that single line in the official code base.