This check the output file name not the data value in the data frame

[djhbs]

https://github.com/atorus-research/xportr/blob/231e959b84aa0f1e71113c85332de33a827e650a/R/write.R#LL33C1-L33C82
Could you please confrim this check refer to the output file name not the data value?
For the file name, if the DM_F can be used when the strict_checks = FALSE，and the DM_F means the full SDTM that contains the parent DM and SUPPDM
Thank you very much.

[djhbs]

I realised that it can be renamed after output by file.rename

[djhbs]

The file.rename not change the internal sas dataset name when opened by SAS universal viewer.
The following is I create a temperary tmp.xpt then rename

[cpiraux]

I have investigated this issue.

https://github.com/atorus-research/xportr/blob/231e959b84aa0f1e71113c85332de33a827e650a/R/write.R#LL33C1-L33C82
Could you please confrim this check refer to the output file name not the data value?
For the file name, if the DM_F can be used when the strict_checks = FALSE，and the DM_F means the full SDTM that contains the parent DM and SUPPDM
Thank you very much.

The check is performed on the filename used to name the XPT file. This name is a metadata in the xpt and it is not updated when the XPT filename is changed.

name <- tools::file_path_sans_ext(basename(path))

if (stringr::str_detect(name, "[^a-zA-Z0-9]")) {
  abort("`.df` cannot contain any non-ASCII, symbol or underscore characters.")
}

write_xpt(data, path = path, version = 5, name = name)

The underscores are allowed in xpt but it was not allowed in FDA sdTCG. I checked the latest version of the FDA sdTCG and it is not clear if underscores are allowed or not.

FDA sdTCG Version March 2018

FDA sdTCG Version October 2023

I tested the conversion from XPT to SAS7BDAT with SAS, and I observed that the name of the dataset is derived from the metadata name, not the file name. If the filename is renamed, the SAS dataset is not renamed.

I think using the filename as the name of the xpt is a good approach. This is also requested in the FDA sdTCG .

I don’t think we can do anything regarding the change of the xpt name when the filename is renamed.

Something to check, if underscores are allowed or not. And, update the name check accordingly in xportr_write().

[bms63]

@cpiraux So we can close this issue as out of scope and make an additional issue regarding underscores?

[djhbs]

@cpiraux Thank yor for detailed explanation. my suggestion is if we can add strict_checks = TRUE as defual, but the file name can be use the "_" when strict_checks = FALSE.