Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pin npm to version 10.8.2 #1451

Merged
merged 4 commits into from
Oct 14, 2024
Merged

build: pin npm to version 10.8.2 #1451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42f1387
build: pin npm to 10.8.2 as a temporary measure because Dependabot us…
gkc Oct 14, 2024
12c8909
Merge remote-tracking branch 'origin/trunk' into gkc-fix-deps
gkc Oct 14, 2024
d5f7e87
build: for the policy webapp, use `npm ci` rather than `npm install` …
gkc Oct 14, 2024
f6bbe22
Merge branch 'trunk' into gkc-fix-deps
gkc Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/multibuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ jobs:
- name: build admin webapp
working-directory: ./apps/admin/webapp
run: |
npm install -g npm@10.9.0
npm install
npm install -g npm@10.8.2
npm ci
npm run build
- if: ${{ matrix.os != 'windows-latest' }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion apps/admin/webapp/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/admin/webapp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
},
"engines": {
"node": ">=v20.15.0 <23",
"npm": "10.9.0"
"npm": "10.8.2"
}
}
4 changes: 2 additions & 2 deletions packages/dart/sshnoports/buildArchive
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ echo "Compiling admin_api"; dart compile exe --verbosity error bin/np_admin.dart
wait
cd ../webapp || exit 1
echo "Building admin webapp"
npm install -g npm@10.9.0 || exit 1
npm install || exit 1
npm install -g npm@10.8.2 || exit 1
npm ci || exit 1
npm run build || exit 1

wait
Expand Down
4 changes: 2 additions & 2 deletions tools/multibuild/Dockerfile.package
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ WORKDIR /noports
# hadolint ignore=DL3008
RUN apt-get update; \
apt-get install -y --no-install-recommends npm; \
npm install -g npm@10.9.0
npm install -g npm@10.8.2

COPY . .

Expand Down Expand Up @@ -42,7 +42,7 @@ RUN dart pub get --enforce-lockfile; \

# Build apps/admin/webapp
WORKDIR /noports/apps/admin/webapp
RUN npm install; \
RUN npm ci; \
npm run build; \
mkdir -p /sshnp/web/admin; \
cp -r ./dist/* /sshnp/web/admin/
Expand Down