Code

refactor: make sshnp more modular#201

Code

Merged

gkc merged 25 commits intotrunkatsign-foundation/noports:trunkfrom gkc-refactor-sshnpatsign-foundation/noports:gkc-refactor-sshnpCopy head branch name to clipboardJun 15, 2023

+863-518

Commits

Commits on Jun 13, 2023

• refactor: complete restructuring of sshnp.dart. Should be no changes in functionality. Have not yet tested using sshrvd, but have found no issues otherwise via manual testing

  gkc

  committed
  7b3ed60

• Merge remote-tracking branch 'origin/trunk' into gkc-refactor-sshnp

  gkc

  committed
  8cdbcac

• fix: added rsa flag into the SSHNP constructor and changed fromCommandLineArgs to pass it to the constructor

  Show description for 38be7c6
  gkc

  committed
  38be7c6

• fix: Changed ..key = '$device$sshrvdNameSpace' to ..key = '$device.$sshrvdNameSpace' (i.e. added a "dot" separator) in getHostAndPortFromSshrvd ... bug crept in because device pre-refactor …

  Show description for 026b0a3
  gkc

  committed
  026b0a3

• fix: set namespaceAware to false when sending notification to sshrvd

  gkc

  committed
  a28473f

Commits on Jun 14, 2023

• refactor: move SSHNP class from bin/sshnp.dart to lib/sshnp.dart

  Show description for 499e963
  gkc

  committed
  499e963

• docs: tidied up imports in bin/sshnp.dart and lib/sshnp.dart

  gkc

  committed
  323bde3

• docs: documented the SSHNP.init() and SSHNP.run() methods

  gkc

  committed
  0aff264

• docs: documented the handleSshnpdResponses method and marked it @VisibleForTesting

  gkc

  committed
  5a02053

• fix: fixed sequencing problem introduced a few commits ago. Generating sshString must happen _after_ we have fetched stuff from sshrvd (if required to)

  gkc

  committed
  a28c44f

Commits on Jun 15, 2023

• added changes

  purnimavenkatasubbu

  committed
  f4e94cd

• Empty-Commit

  purnimavenkatasubbu

  committed
  2a3ab1b

• addressed review comments

  purnimavenkatasubbu

  committed
  b5e06fe

• minor change

  purnimavenkatasubbu

  committed
  61f9ed3

• test: Added first simple unit test (check that exception is thrown if mandatory args are not supplied)

  gkc

  committed
  9fb1a78

• feat: Added throwIfNull parameter (default false) to getUserName and getHomeDirectory in sshnp_utils.dart

  gkc

  committed
  1778c29

• refactor: moved the actual args parsing into its own static method, getSSHNPParams, which does some additional work after first using the ArgParser

  gkc

  committed
  254ad1c

• test: Added test expected value of defaulted args when only mandatory args are supplied

  Show description for 867cd17
  gkc

  committed
  867cd17

• Merge remote-tracking branch 'origin/trunk' into gkc-refactor-sshnp

  gkc

  committed
  7c426c4

• Merge remote-tracking branch 'origin/gkc-refactor-sshnp' into issue_202

  Show description for d42bab6
  gkc

  committed
  d42bab6

• build: Merged from base branch

  gkc

  committed
  257f65d

• fix: fixed typo in option name

  gkc

  committed
  cca9122

• Merge pull request #208 from atsign-foundation/issue_202

  Show description for 0658bf0
  gkc

  authored
  0658bf0

• Merge remote-tracking branch 'origin/gkc-refactor-sshnp' into gkc-refactor-sshnp

  gkc

  committed
  5a74149

• test: added test of parsed args when non-mandatory args are provided

  gkc

  committed
  8651e24