Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make sshnp more modular #201

Merged
merged 25 commits into from
Jun 15, 2023
Merged

refactor: make sshnp more modular #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7b3ed60
refactor: complete restructuring of sshnp.dart. Should be no changes …
gkc Jun 13, 2023
8cdbcac
Merge remote-tracking branch 'origin/trunk' into gkc-refactor-sshnp
gkc Jun 13, 2023
38be7c6
fix: added rsa flag into the SSHNP constructor and changed `fromComma…
gkc Jun 13, 2023
026b0a3
fix: Changed `..key = '$device$sshrvdNameSpace'` to `..key = '$device…
gkc Jun 13, 2023
a28473f
fix: set `namespaceAware` to false when sending notification to sshrvd
gkc Jun 13, 2023
499e963
refactor: move SSHNP class from bin/sshnp.dart to lib/sshnp.dart
gkc Jun 14, 2023
323bde3
docs: tidied up imports in bin/sshnp.dart and lib/sshnp.dart
gkc Jun 14, 2023
0aff264
docs: documented the SSHNP.init() and SSHNP.run() methods
gkc Jun 14, 2023
5a02053
docs: documented the `handleSshnpdResponses` method and marked it @vi…
gkc Jun 14, 2023
a28c44f
fix: fixed sequencing problem introduced a few commits ago. Generatin…
gkc Jun 14, 2023
f4e94cd
added changes
purnimavenkatasubbu Jun 15, 2023
2a3ab1b
Empty-Commit
purnimavenkatasubbu Jun 15, 2023
b5e06fe
addressed review comments
purnimavenkatasubbu Jun 15, 2023
61f9ed3
minor change
purnimavenkatasubbu Jun 15, 2023
9fb1a78
test: Added first simple unit test (check that exception is thrown if…
gkc Jun 15, 2023
1778c29
feat: Added `throwIfNull` parameter (default false) to `getUserName` …
gkc Jun 15, 2023
254ad1c
refactor: moved the actual args parsing into its own static method, g…
gkc Jun 15, 2023
867cd17
test: Added test expected value of defaulted args when only mandatory…
gkc Jun 15, 2023
7c426c4
Merge remote-tracking branch 'origin/trunk' into gkc-refactor-sshnp
gkc Jun 15, 2023
d42bab6
Merge remote-tracking branch 'origin/gkc-refactor-sshnp' into issue_202
gkc Jun 15, 2023
257f65d
build: Merged from base branch
gkc Jun 15, 2023
cca9122
fix: fixed typo in option name
gkc Jun 15, 2023
0658bf0
Merge pull request #208 from atsign-foundation/issue_202
gkc Jun 15, 2023
5a74149
Merge remote-tracking branch 'origin/gkc-refactor-sshnp' into gkc-ref…
gkc Jun 15, 2023
8651e24
test: added test of parsed args when non-mandatory args are provided
gkc Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
478 changes: 6 additions & 472 deletions bin/sshnp.dart
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions bin/sshnpd.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ import 'package:version/version.dart';

// local packages
import 'package:sshnoports/version.dart';
import 'package:sshnoports/home_directory.dart';
import 'package:sshnoports/check_non_ascii.dart';
import 'package:sshnoports/check_file_exists.dart';
import 'package:sshnoports/sshnp_utils.dart';

void main(List<String> args) async {
try {
Expand Down
3 changes: 1 addition & 2 deletions bin/sshrvd.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ import 'package:version/version.dart';

// local packages
import 'package:sshnoports/version.dart';
import 'package:sshnoports/home_directory.dart';
import 'package:sshnoports/check_file_exists.dart';
import 'package:sshnoports/sshnp_utils.dart';

void main(List<String> args) async {
final AtSignLogger logger = AtSignLogger(' sshrvd ');
Expand Down
7 changes: 0 additions & 7 deletions lib/check_file_exists.dart
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions lib/check_non_ascii.dart
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lib/cleanup_sshnp.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// dart packages
import 'dart:io';
// local packages
import 'package:sshnoports/home_directory.dart';
import 'package:sshnoports/sshnp_utils.dart';
// atPlatform packages
import 'package:at_utils/at_logger.dart';

Expand Down
23 changes: 0 additions & 23 deletions lib/home_directory.dart
View file
Open in desktop

This file was deleted.

Loading