refactor: refactor sshnpd_impl.dart for future feature velocity#330

Merged

gkc merged 13 commits intotrunkfrom refactor-for-feature-velocity

Aug 11, 2023

+253-140

Commits on Aug 11, 2023

refactor: move authorized check to beginning of _notificationHandler
gkc
committed
refactor: extract the bodies of case 'ping' and case 'sshpublickey' into their own methods
gkc
committed
sshnpd_impl.dart: use named parameters for _notify method, for easier readability (imo)
gkc
committed
refactor: rename _sshCallback to _handleLegacySshRequestNotification
gkc
committed
refactor: sshnpd_impl.dart: _handleLegacySshRequestNotification : extract everything after parsing the parameters from the notification payload into its own method startReverseSsh which we can …
gkc
committed
refactor sshnpd_impl:
gkc
committed
style: for safety, ensure that the isFromAuthorizedAtSign check is made in every notification handling method which takes an AtNotification as a parameter
gkc
committed
style: relocate isFromAuthorizedAtSign method within the file
gkc
committed
style: comment tidy
gkc
committed
In _handlePingNotification, send the response to notification.from rather than managerAtsign since in future we will likely have multiple atSigns which are authorized to make requests
gkc
committed
style: use single quotes for strings rather than double quotes
gkc
committed
feat: sshnpd_impl: added handler for handling new-style requests (JSON payload via notification with key ssh_request.$device.sshnp) for an ssh session, and handle requests for reverse ssh (which …
gkc
committed
style: ran dart format
gkc
committed